Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing framework setup #31

Merged
merged 18 commits into from
Apr 4, 2019
Merged

Testing framework setup #31

merged 18 commits into from
Apr 4, 2019

Conversation

RvanderLaan
Copy link
Collaborator

Closes #18

Set up test config, debug launch config for VSCode and added a simple Backend test.
The database is mocked with an in-memory implementation of the DBRepository file.

@hummingly hummingly added this to the Alpha v. 1.0 milestone Mar 30, 2019
@hummingly hummingly self-requested a review March 30, 2019 15:25
@hummingly
Copy link
Collaborator

Ok the only thing we're missing is continous integration that actually runs it. Any preferences?

@hummingly
Copy link
Collaborator

Ok, I should have read everything... Sorry for deleting the vscode folder... Still, I prefer CI over vscode as that would check on every commit from anyone and we could check for linting errors and make release drafts.

@RvanderLaan
Copy link
Collaborator Author

I don't have much experience with other CIs, is Travis alright?
It should work, just needs some more fiddling around with the config

@hummingly
Copy link
Collaborator

Travis is fine but windows support isn't great. Some open source projects moved away from it due to some changes but we can make this work first. An alternative could be Azure Pipeline from Microsoft. Support for all plattforms seems to exist.

@RvanderLaan
Copy link
Collaborator Author

Sounds good then, at least for now. Is it okay to merge?
I'll work on the toolbar #29 next if you haven't started already

@hummingly
Copy link
Collaborator

This is really odd that your comment shows up so late. I'm trying to add automated builds and afterwards I can merge this and #23.
You can start working on the toolbar. You only need to add a row to the grid. Do you need for this the icons? If not I could look into the custom icon branch and see what's left.

@RvanderLaan
Copy link
Collaborator Author

Alright, nice! I was just finishing that one up, it still requires one more design iteration since the icons are are a bit too big and can't be scaled down without some hacks

* This should be replaced with a script in package.json
* Not: move to other CI or add another one that supports windows better. Alternatively use Wine.
@hummingly hummingly merged commit 4880737 into master Apr 4, 2019
@hummingly hummingly deleted the testing-setup branch April 5, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants