Add support for mp4, webm, and ogg #583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sincerely hope that it will be implemented into the main branch sooner or later. With some video support, Allusion would be pretty much feature complete, at least for a user like me. |
|
We merged this pull request + HEIC and other new formats in our Allusion Fork, in case someone is interested: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #466, adds support for automatic and on hover playback for videos in gallery view. Also allows playback in main view, which has the side effect of allowing sound from non-video .ogg files. Implementation uses web video elements which replace the image elements used normally. I'm unfamiliar with React or Electron so the implementation may not be optimal.
Caveats: