Network: Removing node inside a cluster and then opening cluster throws error #1291
Comments
|
Errr... yes. At the moment, dynamic data and clusters don't play nice together. I'll update this in future versions. This is also the reason your other issue does not work at the moment. Thanks for the heads-up! Regards |
|
Which one, I forgot. Can you refresh me? |
|
The power is really being able to change the data on the fly. Not static data, that's old school. B) |
|
Yes, but the book-keeping is not up to speed yet. This will have to be implemented nicely and recursively. |
|
Hi, Its all in the clustering file. It needs to listen to the dataChanged event and cleanly and recursively update the bookkeeping. You'll also need to fix #1315 Regards |
|
@mojoaxel I was checking the code regarding this today and I actually made the clustering work and support node removal while clustered. But as I read the code, I got many questions and I wonder if it would be possible to speak with someone about it. |
@AoDev I only noticed this statement just now. Are you still looking for someone to speak with? I am hereby available. |
|
@wimrijnders Thank you. But since February I am not working with vis. I can not work on it at the moment. |
|
@AoDev Yeah, well it was a long time ago, from before I became admin. Well, if you ever want to revisit it, notify me. |
* First working version of updating clustered edge * Added fix for #1315 as well * Enable unit testing for module Network Adds mocks for certain components, in order to let module `Network` be run in unit tests. Changes: - Create a mock object for `hammer.js` when running browserless. The inspiration is taken from [here](visgl/deck.gl#658) - Create a mock function for `window.requestAnimationFrame()` when running browserless in `network/modules/CanvasRenderer.js` - Added unit test for `Network` to show that unit testing for it now works - Fixed naming of container in `test/Graph3d.test.js` Since `hammer.js` is also used in other modules, this fix is potentially an enabler for full-module unit tests for those as well. * Cleanup unit test Network * Added unit test for fix issue #1218 * Adding test for #1315 - Interim save * Completed unit test and fixes for #1315 * Added fixes for #1291 * Added unit test for #1219 * Added header comment for Clustering.js, small fixes * Fix for unit test * Added example networks to unit test * Fix error in loading disassemblerExample * Network unit test final fixes * Fixes for linting * Fixed essential typo * Fixed linting error * Fixed unit test * Fixed unit test again
) * First working version of updating clustered edge * Added fix for almende#1315 as well * Enable unit testing for module Network Adds mocks for certain components, in order to let module `Network` be run in unit tests. Changes: - Create a mock object for `hammer.js` when running browserless. The inspiration is taken from [here](visgl/deck.gl#658) - Create a mock function for `window.requestAnimationFrame()` when running browserless in `network/modules/CanvasRenderer.js` - Added unit test for `Network` to show that unit testing for it now works - Fixed naming of container in `test/Graph3d.test.js` Since `hammer.js` is also used in other modules, this fix is potentially an enabler for full-module unit tests for those as well. * Cleanup unit test Network * Added unit test for fix issue almende#1218 * Adding test for almende#1315 - Interim save * Completed unit test and fixes for almende#1315 * Added fixes for almende#1291 * Added unit test for almende#1219 * Added header comment for Clustering.js, small fixes * Fix for unit test * Added example networks to unit test * Fix error in loading disassemblerExample * Network unit test final fixes * Fixes for linting * Fixed essential typo * Fixed linting error * Fixed unit test * Fixed unit test again
Here is the example: http://jsfiddle.net/umecqna8/
The text was updated successfully, but these errors were encountered: