Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Network: Cannot uncluster nodes when removing a node that has an edge to that cluster #1315

Closed
abcbaby opened this issue Sep 21, 2015 · 3 comments

Comments

@abcbaby
Copy link

abcbaby commented Sep 21, 2015

Here is the example: http://jsfiddle.net/oj61w366/

@AlexDM0
Copy link
Contributor

AlexDM0 commented Sep 21, 2015

Hi,

This is all part of the same shortcoming. It is not possible to use dynamic data around clusters. Once this is addressed, all of these issues will be resolved.

Thanks for reporting.

Regards

@Tooa
Copy link
Member

Tooa commented Sep 24, 2015

"inc" for this feature 👍

@wimrijnders
Copy link
Contributor

FYI I fixed this. However, it's part of a much larger code addition which completely handles the clustering updating due to changing data. It's going to take a while to even it out.

wimrijnders added a commit to wimrijnders/vis that referenced this issue Aug 2, 2017
wimrijnders added a commit to wimrijnders/vis that referenced this issue Aug 2, 2017
wimrijnders added a commit to wimrijnders/vis that referenced this issue Aug 2, 2017
yotamberk pushed a commit that referenced this issue Aug 8, 2017
* First working version of updating clustered edge

* Added fix for #1315 as well

* Enable unit testing for module Network

Adds mocks for certain components, in order to let module `Network` be run in unit tests.

Changes:

- Create a mock object for `hammer.js` when running browserless. The inspiration is taken from [here](visgl/deck.gl#658)
- Create a mock function for `window.requestAnimationFrame()` when running browserless in `network/modules/CanvasRenderer.js`
- Added unit test for `Network` to show that unit testing for it now works
- Fixed naming of container in `test/Graph3d.test.js`

Since `hammer.js` is also used in other modules, this fix is potentially an enabler for full-module unit tests for those as well.

* Cleanup unit test Network

* Added unit test for fix issue #1218

* Adding test for #1315 - Interim save

* Completed unit test and fixes for #1315

* Added fixes for #1291

* Added unit test for #1219

* Added header comment for Clustering.js, small fixes

* Fix for unit test

* Added example networks to unit test

* Fix error in loading disassemblerExample

* Network unit test final fixes

* Fixes for linting

* Fixed essential typo

* Fixed linting error

* Fixed unit test

* Fixed unit test again
primozs pushed a commit to primozs/vis that referenced this issue Jan 3, 2019
)

* First working version of updating clustered edge

* Added fix for almende#1315 as well

* Enable unit testing for module Network

Adds mocks for certain components, in order to let module `Network` be run in unit tests.

Changes:

- Create a mock object for `hammer.js` when running browserless. The inspiration is taken from [here](visgl/deck.gl#658)
- Create a mock function for `window.requestAnimationFrame()` when running browserless in `network/modules/CanvasRenderer.js`
- Added unit test for `Network` to show that unit testing for it now works
- Fixed naming of container in `test/Graph3d.test.js`

Since `hammer.js` is also used in other modules, this fix is potentially an enabler for full-module unit tests for those as well.

* Cleanup unit test Network

* Added unit test for fix issue almende#1218

* Adding test for almende#1315 - Interim save

* Completed unit test and fixes for almende#1315

* Added fixes for almende#1291

* Added unit test for almende#1219

* Added header comment for Clustering.js, small fixes

* Fix for unit test

* Added example networks to unit test

* Fix error in loading disassemblerExample

* Network unit test final fixes

* Fixes for linting

* Fixed essential typo

* Fixed linting error

* Fixed unit test

* Fixed unit test again
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants