Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Edges in dataset may no longer be visible even if valid nodes exist. #3500

Closed
justinharrell opened this issue Sep 29, 2017 · 2 comments
Closed

Comments

@justinharrell
Copy link
Contributor

Based on internal state changes made in #3330 unconnected edges that later become connected due to node dataset modifications no longer appear on the graph until the edge itself is updated.

This is a change in behavior, previously unconnected / invalid edges, those which the from or to node id does not exist, where not drawn on the graph. However when a node was updated or added that completed the connection it was displayed in the graph without further intervention.

The old behavior allowed out of order operations, such that edges could be added before their respective nodes and nodes could be removed and re-added with edges following them properly. Now the developer must update any affected edge if a node is updated completing the connection or always add nodes before their edges.

Discussion in #3330 determined this as a bug and not intended behavior.

I am working on a fix and will submit a PR.

@wimrijnders
Copy link
Contributor

And an extra 👍 for picking it up yourself.

@justinharrell
Copy link
Contributor Author

No problem it allows me to get a better understanding of that area in the code and I happen to have time to devote to it.

yotamberk pushed a commit that referenced this issue Oct 6, 2017
* Cleaned up some whitespace and added test for issue

* Checking for proper removal, better comments and whitespace cleanup
primozs pushed a commit to primozs/vis that referenced this issue Jan 3, 2019
* Cleaned up some whitespace and added test for issue

* Checking for proper removal, better comments and whitespace cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants