This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix issue #3500 #3516
Merged
Fix issue #3500 #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinharrell
force-pushed
the
fix-3500
branch
from
2ac09e1 to
31295af
Compare
wimrijnders
approved these changes
Oct 3, 2017
|
Fixes #3500 |
|
While the code fix is 100% good, I neglected to observe that there is no regression test for this fix. Do you have the energy to add that? I'm thinking of some network where a node is removed and then added again. The test would be that the edges for that node have reconnected. If you don't feel like adding that, I'm prepared to do it myself. It's my oversight. |
|
I pushed a change with a test and some white-space cleanup into the fix branch, would that be a new PR? |
|
Sincerely thanks for your effort. I've never even tried pushing to a merged PR before, is it possible? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes unconnected edges not showing back up if nodes are modified or added that connect them.
I tried a couple approaches, this could probably be optimized some with deeper changes, but I choose to keep the fix as simple as possible.