Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building alpaka examples #527

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Jun 10, 2022

Due to an upstream rename of alpaka's cmake variables (alpaka-group/alpaka#1653), LLAMA's cmake did not correctly detect if alpaka was found, and did not build any alpaka examples. Thus, some modifications in LLAMA did not propagate to the alpaka examples, and they needed fixing.

As a side change in this PR, the index type used in the asynccopy example was changed from size_t to int.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #527 (ccbc3cf) into develop (c77415a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ccbc3cf differs from pull request most recent head 2a36ee9. Consider uploading reports for the commit 2a36ee9 to get more accurate results

@@           Coverage Diff            @@
##           develop     #527   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           63       63           
  Lines         5508     5510    +2     
========================================
+ Hits          5467     5469    +2     
  Misses          41       41           

The naming of alpaka's cmake variables changed upstream.
@bernhardmgruber bernhardmgruber merged commit e08c590 into alpaka-group:develop Jun 13, 2022
@bernhardmgruber bernhardmgruber deleted the fix_alpaka branch June 13, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant