Tweaks to spacing scale table in spacing guidance #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in alphagov/govuk-frontend#2733, these classes don’t actually do anything.
Putting the smaller sizes on the left-hand size seems more logical and fits better with a mobile-first approach.
Going from the smallest size to the largest size just makes more sense.
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
vanitabarrett
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govuk-table__head,govuk-table__bodyandgovuk-table__rowclasses that don't do anything – see Table HTML includes multiple classes that don't do anything govuk-frontend#2733</tr>that had snuck in, the sneaky little thing making our HTML all invalid👉🏻 Preview the change
Before
After
It just makes more sense this way doesn't it?