Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to spacing scale table in spacing guidance #2274

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Tweaks to spacing scale table in spacing guidance #2274

merged 4 commits into from
Jul 28, 2022

Commits on Jul 26, 2022

  1. Remove redundant classes 

    As noted in alphagov/govuk-frontend#2733, these classes don’t actually do anything.
    @36degrees
    36degrees committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    6d7d3c7 View commit details
    Browse the repository at this point in the history

  2. Remove extra closing </tr> tag

    @36degrees
    36degrees committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    60a0409 View commit details
    Browse the repository at this point in the history

  3. Swap small and large screen sizes in spacing table 

    Putting the smaller sizes on the left-hand size seems more logical and fits better with a mobile-first approach.
    @36degrees
    36degrees committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    0efa3f1 View commit details
    Browse the repository at this point in the history

  4. Flip order of spacing scale in table 

    Going from the smallest size to the largest size just makes more sense.
    @36degrees
    36degrees committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    31991a7 View commit details
    Browse the repository at this point in the history