Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config file for prototype kit. #1102

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

nataliecarey
Copy link
Contributor

To accompany the extensions proposal govuk-frontend this config allows govuk-frontend to be an extension in the prototype kit.

Implementation details can be found here alphagov/govuk-prototype-kit#613
Proposal details can be found here alphagov/govuk-design-system-architecture#9

@joelanman
Copy link
Contributor

I think from discussions, we were thinking of being able to list out extensions on the Prototype home page.

For this I think we agreed on adding a 'documentationURL' property, maybe a 'name' too - but maybe these could/should be in package.json and referenced there?

@nataliecarey
Copy link
Contributor Author

Those can easily be added. I'd suggest using the package name to define the name but if having a name field is desirable I don't see any problems with it.

To accompany the extensions proposal this config allows govuk-frontend to be an extension in the prototype kit.

Implementation details can be found here alphagov/govuk-prototype-kit#613
Proposal details can be found here alphagov/govuk-design-system-architecture#9
Copy link
Contributor

@aliuk2012 aliuk2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work,
This will need to be merged and released before we merge the GOV.UK Prototype Kit extensions pr

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matcarey 🙌

@NickColley NickColley merged commit 0caa4e3 into alphagov:master Feb 8, 2019
@NickColley
Copy link
Contributor

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants