Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions Framework #613

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Extensions Framework #613

merged 3 commits into from
Feb 14, 2019

Conversation

nataliecarey
Copy link
Contributor

The implementation of the extension framework discussed in this proposal: alphagov/govuk-design-system-architecture#9

gulp/sass.js Outdated Show resolved Hide resolved
@joelanman
Copy link
Contributor

Just to note, as I was confused after a break :) this doesn't work until the config PR is merged and released in Frontend:

alphagov/govuk-frontend#1102

I guess we can fake it locally until that's the case

@joelanman
Copy link
Contributor

joelanman commented Jan 3, 2019

Currently this PR creates an _extensions.scss file that imports all the extensions scss, and writes it to app/assets/sass

In general it's good to stay out of app as it's for users' own work. We wouldn't want them to ever edit this file as it will be overwritten and changes lost.

In my local copy I've tried writing the file to lib/sass and then in app/assets/sass/application/scss adding:

@import "lib/sass/extensions";

Seems to work.

lib/extensions.js Outdated Show resolved Hide resolved
lib/extensions.js Outdated Show resolved Hide resolved
lib/extensions.js Outdated Show resolved Hide resolved
lib/extensions.js Outdated Show resolved Hide resolved
lib/extensions.js Outdated Show resolved Hide resolved
lib/extensions.js Outdated Show resolved Hide resolved
nataliecarey pushed a commit to dorightdigital/govuk-frontend that referenced this pull request Feb 7, 2019
To accompany the extensions proposal this config allows govuk-frontend to be an extension in the prototype kit.

Implementation details can be found here alphagov/govuk-prototype-kit#613
Proposal details can be found here alphagov/govuk-design-system-architecture#9
Mat Carey and others added 2 commits February 13, 2019 12:58
…stem

As a developer/Designer, I would like to use my departments frontend system
alongside govuk-frontend. So that I can prototype using the same components
and patterns that will be used in production.

This should not be a breaking change for any existing kits.
This is a soft release where GOV.UK Design System team would like HMRC
to test before releasing this more widely.

A proper release with documentation etc. will be done once this has been
battle tested with HMRC.

Co-authored-by: Alistair Laing <alistair.laing@digital.cabinet-office.gov.uk>
Co-authored-by: Hanna Laakso <hanna.laakso@digital.cabinet-office.gov.uk>
This is so we can pick up govuk-prototype-kit.config.json file which
was added to govuk-frontend to support this extensions feature.
Copy link
Contributor

@aliuk2012 aliuk2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🎉 Amazing work !!! 🎉🚀

Thank you @matcarey for all your hard work on this and a BIG thank you 👏to all those in HMRC who supported and allowed @matcarey the time to work on this great feature which everyone can benefit from in the future.

Although its taken some time, I've enjoyed the collaboration between us all. I love the fact this feature will

  • enable quick and easy installation of other departmental frontend systems or components,
  • be backwards compatible,
  • works on Windows.

👍

Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, excited to see what can be done with this feature.

@36degrees
Copy link
Contributor

+100000 on what @NickColley and @aliuk2012 said! It's been great to watch this come together 👍

@aliuk2012 aliuk2012 mentioned this pull request Feb 14, 2019
36degrees pushed a commit to alphagov/govuk-frontend that referenced this pull request Mar 4, 2019
To accompany the extensions proposal this config allows govuk-frontend to be an extension in the prototype kit.

Implementation details can be found here alphagov/govuk-prototype-kit#613
Proposal details can be found here alphagov/govuk-design-system-architecture#9
@simoneduca
Copy link
Contributor

simoneduca commented Mar 8, 2022

DWP Frontend is also using this now. What a great feat, thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

7 participants