-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions Framework #613
Extensions Framework #613
Conversation
Just to note, as I was confused after a break :) this doesn't work until the config PR is merged and released in Frontend: I guess we can fake it locally until that's the case |
Currently this PR creates an In general it's good to stay out of In my local copy I've tried writing the file to
Seems to work. |
To accompany the extensions proposal this config allows govuk-frontend to be an extension in the prototype kit. Implementation details can be found here alphagov/govuk-prototype-kit#613 Proposal details can be found here alphagov/govuk-design-system-architecture#9
…stem As a developer/Designer, I would like to use my departments frontend system alongside govuk-frontend. So that I can prototype using the same components and patterns that will be used in production. This should not be a breaking change for any existing kits. This is a soft release where GOV.UK Design System team would like HMRC to test before releasing this more widely. A proper release with documentation etc. will be done once this has been battle tested with HMRC. Co-authored-by: Alistair Laing <alistair.laing@digital.cabinet-office.gov.uk> Co-authored-by: Hanna Laakso <hanna.laakso@digital.cabinet-office.gov.uk>
This is so we can pick up govuk-prototype-kit.config.json file which was added to govuk-frontend to support this extensions feature.
fa84ffd
to
f933ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🎉 Amazing work !!! 🎉🚀
Thank you @matcarey for all your hard work on this and a BIG thank you 👏to all those in HMRC who supported and allowed @matcarey the time to work on this great feature which everyone can benefit from in the future.
Although its taken some time, I've enjoyed the collaboration between us all. I love the fact this feature will
- enable quick and easy installation of other departmental frontend systems or components,
- be backwards compatible,
- works on Windows.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, excited to see what can be done with this feature.
+100000 on what @NickColley and @aliuk2012 said! It's been great to watch this come together 👍 |
To accompany the extensions proposal this config allows govuk-frontend to be an extension in the prototype kit. Implementation details can be found here alphagov/govuk-prototype-kit#613 Proposal details can be found here alphagov/govuk-design-system-architecture#9
DWP Frontend is also using this now. What a great feat, thanks ❤️ |
The implementation of the extension framework discussed in this proposal: alphagov/govuk-design-system-architecture#9