Add gutters to the header consistent with the grid #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1144
|
Internet Explorer 8 is rendering oddly but I don't think it's related to this change, I'll try and fix that first so we can know that doing this work doesn't break Internet Explorer 8... |
|
🎉 |
|
This makes sense to me, but it'd be good if @dashouse could take a look as well. |
36degrees
approved these changes
Jan 17, 2019
|
(Needs a changelog entry) |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1144
|
🚢 |
This allows the header to line up with the grid properly.
NickColley
force-pushed
the
adjust-spacing-for-header-to-match-grid
branch
from
91260b0
to
332cd43
Compare
|
I'm happy this works well in IE8 now that the other bug has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the header to line up with the grid properly.
Screenshots
Desktop
Before
After
Above tablet
Before
After
Tablet
Before
After
To do