Add required imports to form-group #1226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing: ```scss @import "~govuk-frontend/objects/form-group"; ``` I get: ``` ERROR in ./src/objects/form-group/_form-group.module.scss (./node_modules/css-loader??ref--6-1!./node_modules/sass-loader/lib/loader.js!./src/objects/form-group/_form-group.module.scss) Module build failed (from ./node_modules/sass-loader/lib/loader.js): @include govuk-exports("govuk/objects/form-group") { ^ No mixin named govuk-exports in /node_modules/govuk-frontend/objects/_form-group.scss (line 1, column 10) ``` Adding ```scss @import "~govuk-frontend/settings/all"; @import "~govuk-frontend/helpers/all"; ``` Makes it compile ok, and adding ```scss @import "~govuk-frontend/tools/all"; ``` Seems to be needed to get the correct CSS output.
|
This also needs to be reviewed on other Scss files in objects, e.g. width-container. |
|
Hey @penx ! As far as I can tell, it does look like these files should be declaring their dependencies like you've described. I've had a quick look and this looks to be the same case with most of the files, I'll ping the team to see if this was intentional. We could try to have a high level smoke test that imports all files on their own and see if they fail? |
|
Yep, great work thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing:
I get:
Adding
Makes it compile ok, and adding
Seems to be needed to get the correct CSS output.
In my opinion this would be better addressed in govuk-frontend direct.