Test that parts of GOV.UK Frontend can be imported individually #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1235
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1235
36degrees
force-pushed
the
add-tests-imports
branch
from
d2f01f4
to
dcd297e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1235
NickColley
reviewed
Mar 5, 2019
| const sassFiles = glob.sync(`${configPaths.src}/overrides/**/*.scss`) | ||
|
|
||
| it.each(sassFiles)('%s renders to CSS without errors', (file) => { | ||
| return renderSass({ file: file }) |
There was a problem hiding this comment.
Non-blocking you can use renderSass({ file }) here
NickColley
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
This looks great to me, tests are very clear.
Will need a changelog entry, @36degrees could you make sure to thank @penx for helping us with this one too 👍
|
Yay thanks! |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1235
36degrees
force-pushed
the
add-tests-imports
branch
from
c484aa1
to
df54ea9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that files within certain layers render to CSS without error when imported individually:
This will test that e.g. files within these layers import their own dependencies.
This builds on the work done by @penx in #1226.
Closes #1226