Deprecate IE8 related settings and tools #3343
Conversation
Update internal references to the `govuk-if-ie8` and `govuk-not-ie8` mixins to call the new private versions of the mixins which do not trigger the warnings.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3343
|
Looks brill. Noticed a fair few of them in: Just mentioning #3164 too as it'll need the new ie8.test.js test adjusting Note: Not necessarily related, but all the Sass "tooling" tests spin up the Review app as they're named to match the "JavaScript behaviour tests" project. Annoying you could use |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3343
|
@claireashworth I've added a changelog entry for this, but it feels a little clunky (especially the title) – would you like to take a look now or happy to take a look when we come to do the release? |
|
I'll take a look now
…On Tue, 28 Feb 2023 at 14:35, Oliver Byford ***@***.***> wrote:
@claireashworth <https://github.com/claireashworth> I've added a
changelog entry for this, but it feels a little clunky (especially the
title) – would you like to take a look now or happy to take a look when we
come to do the release?
—
Reply to this email directly, view it on GitHub
<#3343 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMXUGHFZDBNAWWZMZVFKTY3WZYELBANCNFSM6AAAAAAVJUOTI4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Claire Ashworth (she/her)
Content Lead/Technical Writer
07793206027
|
CHANGELOG.md
Outdated
| @@ -43,6 +43,19 @@ Disabling links that are styled to look like buttons will not be supported by fu | |||
|
|
|||
| This was added in [pull request #3326: Deprecate `govuk-button--disabled` class](https://github.com/alphagov/govuk-frontend/pull/3326). | |||
|
|
|||
| #### Stop using the `govuk-if-ie8` and `govuk-not-ie8` mixins and the `$govuk-is-ie8` and `$govuk-ie8-breakpoint` settings | |||
There was a problem hiding this comment.
Alternative headings:
Stop using the mixins govuk-if-ie8 and govuk-not-ie8 and the breakpoint settings $govuk-is-ie8 and $govuk-ie8-breakpoint
or
Stop using the mixins and breakpoint settings for generating IE8 stylesheets
or
Stop using the deprecated IE8 mixins and settings.
It depends how much detail you want in the header.
There was a problem hiding this comment.
@36degrees I've made some suggestions, but the rest looks fine to me.
36degrees
force-pushed
the
deprecate-ie8-vars-mixins
branch
from
7b327e3 to
512fbdb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3343
We'll be removing IE8 support in v5.0. Following our guidance for deprecating and removing features, deprecate the Sass settings and mixins used for building IE8 specific stylesheets:
$govuk-is-ie8setting$govuk-ie8-breakpointsettinggovuk-if-ie8mixingovuk-not-ie8mixinUpdate references to the mixins within GOV.UK Frontend so that they do not generate warnings – we only want warnings to be generated where service teams are using the
govuk-if-ie8andgovuk-not-ie8mixins in their own code.Suppress IE8 related warnings when generating the IE8 stylesheets for the review app or for the
distversion of GOV.UK Frontend.Deprecating these features communicates this intent to service teams and allows them to make changes ahead of time, reducing the effort involved in upgrading to the next major version.
Closes #3163