Build tasks: Clearly show subdirectory paths #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
changed the title
colinrotherham
force-pushed
the
build-paths
branch
from
0f69491 to
bbb70de
Compare
colinrotherham
force-pushed
the
build-paths
branch
from
bbb70de to
94ae8ec
Compare
colinrotherham
force-pushed
the
build-paths
branch
from
94ae8ec to
01f19fb
Compare
colinrotherham
force-pushed
the
build-paths
branch
from
01f19fb to
1039b99
Compare
colinrotherham
force-pushed
the
build-paths
branch
from
1039b99 to
d4db145
Compare
romaricpascal
approved these changes
Mar 17, 2023
| @@ -20,7 +20,7 @@ export default async () => { | |||
| .filter(filterPath([`${componentName}/macro.njk`])) | |||
|
|
|||
| return { | |||
| importFrom: slash(relative(configPaths.src, join(configPaths.components, macroPath))), | |||
| importFrom: slash(relative(paths.src, join(paths.src, 'govuk/components', macroPath))), | |||
There was a problem hiding this comment.
question It's not your change, but isn't that equivalent to join('govuk/components', macroPath)?
There was a problem hiding this comment.
@romaricpascal Spot on! Hidden away by configPaths.components until now
Will fix before merging, thanks again
This commit removes non-root paths from the paths config It’s now easy to determine “source” versus “review app” directories ```js join(paths.src, 'govuk/assets') join(paths.src, 'govuk/components') join(paths.app, 'views') join(paths.app, 'views/layouts') ```
colinrotherham
force-pushed
the
build-paths
branch
from
d4db145 to
f14899f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to clearly show our build paths as part of:
Whilst pairing on #3318 it wasn't obvious which areas of the repo are being copied, written or built from config paths
For example, what's the difference between these three?
configPaths.componentsjoin(configPaths.package, 'govuk/components')join(configPaths.package, 'govuk-esm/components')I've ensured that only top-level paths are found in config/paths.js so their locations are clear:
Top level
Source
Review app