Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the kit instructions step 9 is impossible for current releases #1022

Closed
lfdebrux opened this issue May 11, 2021 · 3 comments · Fixed by #1023
Closed

Updating the kit instructions step 9 is impossible for current releases #1022

lfdebrux opened this issue May 11, 2021 · 3 comments · Fixed by #1023
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve. Submitted by user issues on behalf of users

Comments

@lfdebrux
Copy link
Member

Step 9 in the steps to update to the latest version is not possible for prototype kit >= 9.12.0, as there is no folder app/assets/sass/components (it was removed in #983).

Suggestion

We should either change the step to clarify what to do if the folder is not present in a release, or remove the step altogether.

Evidence (where applicable)

A question about this step was asked in the x-gov prototype kit Slack channel https://ukgovernmentdigital.slack.com/archives/C0647LW4R/p1620720817157100.
@lfdebrux lfdebrux added 🕔 Hours A well understood issue which we expect to take less than a day to resolve. Submitted by user issues on behalf of users and removed awaiting triage labels May 11, 2021
@36degrees
Copy link
Contributor

Removing the step gets my vote. That's what I would have done if I hadn't missed it in #983!

@lfdebrux
Copy link
Member Author

@36degrees If a user is updating from a version which does have app/assets/scss/components to a version which doesn't, should they delete app/assets/scss/components?

@joelanman
Copy link
Contributor

@lfdebrux I don't think they need to, so maybe best to skip for simplicity?

lfdebrux added a commit that referenced this issue May 11, 2021
@lfdebrux
Update updating the kit instructions
f323ae6 
Step 9 from steps on updating to the latest version is out of date,
as `app/assets/scss/components` was removed in #983.

Users should not need to remove the `app/assets/scss/components` folder
if they already have one, so we can just remove the step.

Closes #1022.
@lfdebrux lfdebrux mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕔 Hours A well understood issue which we expect to take less than a day to resolve. Submitted by user issues on behalf of users
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update updating the kit instructions alphagov/govuk-prototype-kit
3 participants
@36degrees @lfdebrux @joelanman