Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the outdated 'GOV.UK uses cookies to make the site simpler' cookie banner #983

Merged
merged 6 commits into from
Feb 3, 2021

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Jan 26, 2021

In preparation for the publication of a new cookie banner component in the Design System, remove the old 'GOV.UK uses cookies to make the site simpler' cookie banner from the Prototype Kit.

Screenshot 2021-01-26 at 11 37 07

  • Remove the cookie banner from layouts and stylesheets
  • Remove the server logic and config for the cookie banner, including a dependency on cookie-parser
  • Update the cookies page to remove references to using cookies to record notifications that the user has seen, the seen_cookie_message cookie, and showing a cookie banner or message.

Closes #859

No content changes have been made in this commit – only converting tabs to spaces.
Remove references to using cookies to record notifications that the user has seen, the seen_cookie_message cookie, and showing a cookie banner or message.
@36degrees
Copy link
Contributor Author

Verified that if none of the changes are made to the app folder (i.e. if the app folder still includes the partial, stylesheet etc) that this still works as expected – because shouldShowCookieMessage is never set to true, the cookie-banner partial never outputs anything.

(Verified by resetting the app folder to mirror master by running git checkout master app/ and then running the kit)

@36degrees 36degrees changed the title Remove the old cookie banner Remove the old style "GOV.UK uses cookies to make the site simpler" cookie banner Feb 3, 2021
@36degrees 36degrees merged commit 06a458f into master Feb 3, 2021
@36degrees 36degrees deleted the remove-old-cookie-banner branch February 3, 2021 13:59
@EoinShaughnessy
Copy link
Contributor

EoinShaughnessy commented Feb 4, 2021

@36degrees As per style guide advice, can we make the quotes in the issue title single instead of double?

Also, I wonder should we change 'old style' to 'outdated.' 'Old style' seems like plainer English, but in this context we'd be associating 'old' with 'obsolete' - which probably isn't inclusive.

@36degrees
Copy link
Contributor Author

@EoinShaughnessy good call on both. If it's OK with you, suggest we make those changes at the point we update the release notes to add the version number (as part of the release process)

@EoinShaughnessy
Copy link
Contributor

@36degrees Sounds good!

@hannalaakso hannalaakso mentioned this pull request Feb 8, 2021
@EoinShaughnessy EoinShaughnessy changed the title Remove the old style "GOV.UK uses cookies to make the site simpler" cookie banner Remove the outdated 'GOV.UK uses cookies to make the site simpler' cookie banner Feb 9, 2021
lfdebrux added a commit that referenced this pull request May 11, 2021
Step 9 from steps on updating to the latest version is out of date,
as `app/assets/scss/components` was removed in #983.

Users should not need to remove the `app/assets/scss/components` folder
if they already have one, so we can just remove the step.

Closes #1022.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove out of date cookie banner from Prototype Kit
4 participants