Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike script to build release with dev dependencies stripped out #1397

Closed
wants to merge 3 commits into from

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Jun 15, 2022

First pass at a script that would mean releases don't include dev dependencies, making installation of the kit quicker for all users.

Notes:

  • This would affect our ability to use the download zip feature. The zip downloads would no longer be like releases.
  • We would also have extra files appearing on each page on GitHub for each release, I don’t think we can tell GitHub not to create a source code zip. So with a build process we would have to be careful about how we communicate to users on the GitHub release page about which file to download.

Not addressed in this spike: tests of the release script, using the release script for tests

@lfdebrux lfdebrux changed the title # Do not modify or remove the line above. # Everything below it will be ignored. Add script to build release with dev dependencies stripped out Jun 15, 2022
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-ldeb-add-b-dnp7fy June 15, 2022 10:26 Inactive
@lfdebrux lfdebrux marked this pull request as draft June 15, 2022 10:26
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-ldeb-add-b-dnp7fy June 15, 2022 10:31 Inactive
@lfdebrux
Copy link
Member Author

I've created a draft release to share the archive generated from this script, and to show what the release page would look like:

https://github.com/alphagov/govuk-prototype-kit/releases/tag/untagged-f21dbf728816b9509765

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-ldeb-add-b-dnp7fy June 15, 2022 10:45 Inactive
@lfdebrux lfdebrux changed the title Add script to build release with dev dependencies stripped out Spike script to build release with dev dependencies stripped out Jun 15, 2022
@lfdebrux lfdebrux closed this Jun 16, 2022
@lfdebrux lfdebrux deleted the ldeb-add-build-release-step branch June 16, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants