Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GOVUK Frontend v4.2.0 #1476

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Update to GOVUK Frontend v4.2.0 #1476

merged 2 commits into from
Jul 22, 2022

Conversation

joelanman
Copy link
Contributor

@joelanman joelanman commented Jul 21, 2022

Closes #1442

This also adds the new pagination component to app/views/layout.html

I don't think the update process covers this change, we may need to think about that

The release notes mention "Replace deprecated govuk-header__link--service-name class in the header" - we have a reference to this in cypress, I'm not sure if it needs updating?

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-update-gov-psk3fe July 21, 2022 09:40 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-protot-update-gov-psk3fe July 21, 2022 09:48 Inactive
@lfdebrux
Copy link
Member

I don't think the update process covers this change, we may need to think about that

I think we can either add to the user steps for the update process, or we could move the layout/template views into the lib folder, similar to #1388.

@joelanman
Copy link
Contributor Author

joelanman commented Jul 21, 2022

I think it's likely some people have edited layout so I'm not sure it's safe to move it to lib or automatically update it.

For now maybe we just tell people as part of the release notes that they should add this line to app/views/layout.html if they're updating @NoraGDS, and raise an issue to look at this properly in the future

@lfdebrux
Copy link
Member

The release notes mention "Replace deprecated govuk-header__link--service-name class in the header" - we have a reference to this in cypress, I'm not sure if it needs updating?

It's not strictly necessary, it looks like @BenSurgisonGDS already anticipated this issue and updated the code to be forwards compatible in 68cde6f

That said removing the reference to that class would make the code slightly neater, so up to you.

Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM 👍

@joelanman joelanman merged commit 95aff53 into main Jul 22, 2022
@joelanman joelanman deleted the update-govukfrontend-4.2.0 branch July 22, 2022 09:53
@lfdebrux lfdebrux mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest version of GOV.UK Frontend
3 participants