Associate the plugin search input with its label #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search input on the plugin list page does not have a programatically label because the label is not currently associated with the input. Rather than using the separate `govukLabel` macro, pass the label options to the `govukInput` macro and let it take care of associating the label for us. We can also use the `govuk-label--s` modifier rather than a font weight override.
36degrees
force-pushed
the
plugin-search-input
branch
from
ff5a55d
to
653d635
Compare
colinrotherham
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a quick look to see if any issues were listed in developer tools for #2393 and noticed this was being flagged.
The search input on the plugin list page does not have a programatically label because the label is not currently associated with the input.
Rather than using the separate
govukLabelmacro, pass the label options to thegovukInputmacro and let it take care of associating the label for us.We can also use the
govuk-label--smodifier rather than a font weight override.