Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate the plugin search input with its label #2398

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Associate the plugin search input with its label #2398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
481e5fa
Associate plugin search input and label
36degrees Feb 26, 2024
653d635
Document in CHANGELOG
36degrees Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- [#2327: Use GOV.UK Frontend v5 on management pages and tests](https://github.com/alphagov/govuk-prototype-kit/pull/2327)
- [#2394: Update Browsersync to resolve `axios` vulnerability](https://github.com/alphagov/govuk-prototype-kit/pull/2394)
- [#2395: Update to GOV.UK Frontend v5.2.0 on management pages](https://github.com/alphagov/govuk-prototype-kit/pull/2395)
- [#2398: Associate the plugin search input with its label](https://github.com/alphagov/govuk-prototype-kit/pull/2398)
- [#2399: Stop accidentally cleaning up non-expired sessions](https://github.com/alphagov/govuk-prototype-kit/pull/2399)

## 13.16.0
Expand Down
10 changes: 4 additions & 6 deletions lib/nunjucks/views/manage-prototype/plugins.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{% extends "views/manage-prototype/layout.njk" %}
{% from "govuk/components/button/macro.njk" import govukButton %}
{% from "govuk/components/label/macro.njk" import govukLabel %}
{% from "govuk/components/input/macro.njk" import govukInput %}
{% from "govuk/components/tag/macro.njk" import govukTag %}

Expand Down Expand Up @@ -48,13 +47,12 @@
{% if isSearchPage %}
<div class="govuk-!-margin-bottom-5">
<div id="search-container">
{{ govukLabel({
text:"Search",
classes:"govuk-!-font-weight-bold"
}) }}

{{ govukInput({
id: "search",
label: {
text: "Search",
classes: "govuk-label--s"
},
classes: "govuk-!-width-one-half",
formGroup: {
classes: "govuk-!-margin-bottom-3"
Expand Down
Loading