Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link context in step-by-step templates #647

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

eronisko
Copy link
Contributor

Link context (price) wasn't showing correctly previously

Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eronisko this looks great.

Just requires a second team member to review

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eronisko 🙌 Would you be okay to also fix the link for "Get a provisional licence" in start-with-step-by-step.html (the content should be "Apply for your first provisional driving licence", same as step-by-step-navigation.html)

eronisko and others added 2 commits November 26, 2018 12:12
Link context (price) wasn't showing correctly previously
@kr8n3r
Copy link

kr8n3r commented Nov 26, 2018

thanks @hannalaakso I pushed up the fix to that page as well

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kr8n3r kr8n3r merged commit 3ea9eaa into alphagov:master Nov 26, 2018
@kr8n3r kr8n3r added this to the [NEXT] milestone Nov 26, 2018
@joelanman joelanman mentioned this pull request Jan 16, 2019
@aliuk2012 aliuk2012 removed this from the [NEXT] milestone Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants