Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link context in step-by-step templates #647

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Fix link context in step-by-step templates #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f71c5b
Fix link context in step-by-step templates
eronisko Nov 22, 2018
fa1bff4
Document in changelog
Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Unreleased

Fixes:

- [#647 Fix link context in step-by-step templates](https://github.com/alphagov/govuk-prototype-kit/pull/647)

Internal:

- [#640 Replace Mocha with Jest](https://github.com/alphagov/govuk-prototype-kit/pull/640)
Expand Down
8 changes: 3 additions & 5 deletions docs/views/templates/start-with-step-by-step.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ <h3 class="app-step-nav__title">
<div class="app-step-nav__panel js-panel" id="step-panel-get-a-provisional-licence-2">
<ol class="app-step-nav__list " data-length="1">
<li class="app-step-nav__list-item js-list-item ">
<a data-position="2.1" class="app-step-nav__link js-link" href="#">£34 to £43</span>
<a data-position="2.1" class="app-step-nav__link js-link" href="#">Apply for your first provisional driving licence <span class="app-step-nav__context">£34 to £43</span></span>
</a>
</li>
</ol>
Expand Down Expand Up @@ -208,8 +208,7 @@ <h3 class="app-step-nav__title">

<ol class="app-step-nav__list " data-length="5">
<li class="app-step-nav__list-item js-list-item ">
<a data-position="5.1" class="app-step-nav__link js-link" href="#">£23</span>
</a>
<a data-position="5.1" class="app-step-nav__link js-link" href="#">Book your theory test <span class="app-step-nav__context">£23</span></a>
</li>
<li class="app-step-nav__list-item js-list-item ">
<a data-position="5.2" class="app-step-nav__link js-link" href="#">What to take to your test </a>
Expand Down Expand Up @@ -251,8 +250,7 @@ <h3 class="app-step-nav__title">

<ol class="app-step-nav__list " data-length="5">
<li class="app-step-nav__list-item js-list-item ">
<a data-position="6.1" class="app-step-nav__link js-link" href="#">£62 to £75</span>
</a>
<a data-position="6.1" class="app-step-nav__link js-link" href="#">Book your driving test <span class="app-step-nav__context">£62 to £75</span></a>
</li>
<li class="app-step-nav__list-item js-list-item ">
<a data-position="6.2" class="app-step-nav__link js-link" href="#">What to take to your test </a>
Expand Down
5 changes: 2 additions & 3 deletions docs/views/templates/step-by-step-navigation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,7 @@ <h2 class="app-step-nav__title">

<ol class="app-step-nav__list " data-length="5">
<li class="app-step-nav__list-item js-list-item ">
<a data-position="5.1" class="app-step-nav__link js-link" href="#">£23</span>
</a>
<a data-position="5.1" class="app-step-nav__link js-link" href="#">Book your theory test <span class="app-step-nav__context">£23</span></a>
</li>
<li class="app-step-nav__list-item js-list-item ">
<a data-position="5.2" class="app-step-nav__link js-link" href="#">What to take to your test </a>
Expand Down Expand Up @@ -241,7 +240,7 @@ <h2 class="app-step-nav__title">

<ol class="app-step-nav__list " data-length="5">
<li class="app-step-nav__list-item js-list-item ">
<a data-position="6.1" class="app-step-nav__link js-link" href="#">£62 to £75</span>
<a data-position="6.1" class="app-step-nav__link js-link" href="#">Book your driving test <span class="app-step-nav__context">£62 to £75</span></a>
</a>
</li>
<li class="app-step-nav__list-item js-list-item ">
Expand Down