Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#153091168] Add autopilot plugin to cf-cli docker image #103

Merged
merged 2 commits into from
Dec 14, 2017

Conversation

46bit
Copy link

@46bit 46bit commented Dec 14, 2017

What

We are updating the product page deployment to deploy with a host of www.cloud.service.gov.uk (see alphagov/paas-product-page#44.) For this we need the autopilot cf plugin to be available in cf-cli Docker image being used.

How to review

Code review

Who can review

Not @46bit @camelpunch

Michael Mokrysz added 2 commits December 14, 2017 11:59
Using version 0.0.3. Note that the plugin reports v0.0.2 because of a
bug in the release.
@bandesz bandesz self-requested a review December 14, 2017 12:47
Copy link
Contributor

@bandesz bandesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to include and use a second zdd plugin? What is the problem with blue-green-deploy?

@46bit
Copy link
Author

46bit commented Dec 14, 2017

@bandesz Sorry, that context was missed. The blue-green-deploy plugin ignores new settings in the app manifest. We have to add new routes to the manifest.json and have them be applied. Autopilot only pays attention to the app manifest, so we've switched to use it here.

@bandesz
Copy link
Contributor

bandesz commented Dec 14, 2017

I'm going to approve this now, but just a note that this plugin is not maintained at all and Trade Tariff also reported a strange error: contraband/autopilot#49. We could write the same deployment process with a couple of cf commands.

@camelpunch
Copy link
Contributor

There's now a version 0.0.4 merged into the official repo: cloudfoundry/cli-plugin-repo#193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants