This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
[#153091168] Deploy to www.(system domain) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to autopilot instead of blue-green deploy plugin This allows us to use the CF manifest as a source of truth for routes - Use a script to generate the manifest for deployment - The base manifest declares the existing paas-product-page.cloudapps.digital because we want to keep serving it This change requires a corresponding change to the Docker image, to provide the autopilot plugin.
46bit
force-pushed
the
paas-redirects-153091168
branch
from
2bcf055 to
4d41c0f
Compare
46bit
changed the title
LeePorte
approved these changes
Dec 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The product page app is mostly served as HTML files. However, we redirect
.htmlrequests to strip out the extension. Before this change, this redirect would take people onto thecloudapps.digitaldomain. For instance, visitinghttps://www.cloud.service.gov.uk/get-started.htmlgives a redirect tohttps://paas-product-page.cloudapps.digital/get-started. This is because the app is only seeing a hostname ofpaas-product-page.cloudapps.digital.This adds a new hostname to the deployed app, which in production will be
www.cloud.service.gov.ukand in development would bewww.${DEPLOY_ENV}.dev.cloudpipeline.digital. We are separately configuring CloudFront to provideHost: www.cloud.service.gov.uk, and this new route will mean the app will receive such requests and redirect correctly.How to review
Code review.
Who can review
Not @camelpunch @46bit