PP-8729: Fix github release resource #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github recently changed their release formatting behind the scenes (see concourse/github-release-resource#107). The fix has been pushed for the Concourse github-release-resource, but this is not available in the version of Concourse that BigConcourse is currently running (v7.2.0). Given it may be 'a while' before BigConcourse reaches 7.5.0+, we can instead pin to the version of the resource repo that contains the fix, and specify this as a resource_type. The naming of the resource type is a bit clumsy but I want it to be clear that this is a version of the resource, not the bleeding edge of the repo. Suggestions for a better name welcome.
jfharden
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the resource check error we were seeing:
illegal base64 data at input byte 2Github recently changed their Graphqa release formatting behind the scenes (see concourse/github-release-resource#107). The fix has been pushed for the Concourse
github-release-resource, but this is not available in the version of Concourse that BigConcourse is currently running (v7.2.0). Given it may be 'a while' before BigConcourse reaches 7.5.0+, we can instead pin to the version of the resource repo that contains the fix, and specify this as aresource_type.The naming of the resource type is a bit clumsy but I want it to be clear that this is a version of the resource, not the bleeding edge of the repo. Suggestions for a better name welcome.
Tested this on the pipeline already - the resource (v21 of the smoke tests code) is fetched successfully, and the release tag is pinned to 1.5.5 (click the cogs on the right of the
check: smoke-tests-git-releasebar).