-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphqa api changes #107
Graphqa api changes #107
Conversation
Signed-off-by: kbilchenko <kirya7@gmail.com>
Signed-off-by: kbilchenko <kirya7@gmail.com>
246572b
to
2a6b5d8
Compare
Signed-off-by: kbilchenko <kirya7@gmail.com>
22235d0
to
30fec67
Compare
Hi could you add a link to the github graphql change log please? Thx! |
@xtremerui it's not included in the changelog. the databaseId was added here: https://docs.github.com/en/graphql/overview/changelog#schema-changes-for-2021-06-07 But if you look at the graphql api documentation the it is wierd though because it is mentioned in the scalars, and described as a base64 encoded string, but if you look at the api it's no longer that. |
@xtremerui I'm not sure how helpful will be this, but github_communtiy there is an answer about the id, and it was working for some time, until today when I was working on this graphql client the |
@xtremerui one more small note, we already build the image of updated resource and replaced the build in github-release resource inside worker, and now it's working fine on our side. |
I am wondering the circumstance of using The changes here shows it should use Also, the way we decodes the |
This one I left so self-hosted installation, not sure when the |
any chance we are going to get this pushed out to docker hub? I only saw dev and dev-ubuntu tag from today. |
@techgaun just cut a new release. it should be up now. |
we need the changes in #107 for 6.7 branch as well Signed-off-by: Rui Yang <ruiya@vmware.com>
Apologies for the noob question - our concourse pipeline is failing with:
I can see a fix has been pushed for the github-release resource, but wondering how to force our concourse instance to pick up the new version? |
@adamdossa add the following custom resource type to your
|
Github recently changed their release formatting behind the scenes (see concourse/github-release-resource#107). The fix has been pushed for the Concourse github-release-resource, but this is not available in the version of Concourse that BigConcourse is currently running (v7.2.0). Given it may be 'a while' before BigConcourse reaches 7.5.0+, we can instead pin to the version of the resource repo that contains the fix, and specify this as a resource_type. The naming of the resource type is a bit clumsy but I want it to be clear that this is a version of the resource, not the bleeding edge of the repo. Suggestions for a better name welcome.
Github recently changed their release formatting behind the scenes (see concourse/github-release-resource#107). The fix has been pushed for the Concourse github-release-resource, but this is not available in the version of Concourse that BigConcourse is currently running (v7.2.0). Given it may be 'a while' before BigConcourse reaches 7.5.0+, we can instead pin to the version of the resource repo that contains the fix, and specify this as a resource_type. The naming of the resource type is a bit clumsy but I want it to be clear that this is a version of the resource, not the bleeding edge of the repo. Suggestions for a better name welcome.
After today github release the id field is now changing the format, so resource is returning
error running command: illegal base64 data at input byte 2
https://docs.github.com/en/graphql/reference/objects#release