Merge pull request #156 from NaokiTsuchiya/issue/155

Set ALPS profile title to the title element of index.html
alps-asd · May 28, 2022 · 64f0f3d · 64f0f3d
2 parents 4fd7b61 + a9d5615
commit 64f0f3d
Show file tree

Hide file tree

Showing 8 changed files with 84 additions and 43 deletions.
diff --git a/docs/blog/index.html b/docs/blog/index.html
@@ -1,6 +1,6 @@
 <html lang="en">
 <head>
-    <title>ALPS</title>
+    <title>ALPS Blog</title>
     <meta charset="UTF-8">
     <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/github-markdown-css/3.0.1/github-markdown.min.css">
     <style>
@@ -59,4 +59,4 @@ <h1>ALPS Blog</h1>
 
     </div>
 </body>
-</html>
+</html>
diff --git a/docs/blog/index.md b/docs/blog/index.md
@@ -21,4 +21,4 @@ An ALPS profile example for ASD
    * [collection](docs/tag.collection.md)
    * [item](docs/tag.item.md)
  * Links
-   * rel: issue <a rel="issue" href="https://github.com/alps-asd/app-state-diagram/issues">https://github.com/alps-asd/app-state-diagram/issues</a>
+   * rel: issue <a rel="issue" href="https://github.com/alps-asd/app-state-diagram/issues">https://github.com/alps-asd/app-state-diagram/issues</a>
diff --git a/docs/filter/index.html b/docs/filter/index.html
@@ -1,6 +1,6 @@
 <html lang="en">
 <head>
-    <title>ALPS</title>
+    <title>ALPS example</title>
     <meta charset="UTF-8">
     <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/github-markdown-css/3.0.1/github-markdown.min.css">
     <style>

diff --git a/docs/filter/tag_profile.svg b/docs/filter/tag_profile.svg
diff --git a/docs/todomvc/index.html b/docs/todomvc/index.html
@@ -1,6 +1,6 @@
 <html lang="en">
 <head>
-    <title>ALPS</title>
+    <title>MVC ToDo List</title>
     <meta charset="UTF-8">
     <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/github-markdown-css/3.0.1/github-markdown.min.css">
     <style>

diff --git a/src/IndexPage.php b/src/IndexPage.php
@@ -43,7 +43,7 @@ public function __construct(Profile $profile, string $mode = DumpDocs::MODE_HTML
         $ext = $mode === DumpDocs::MODE_MARKDOWN ? 'md' : DumpDocs::MODE_HTML;
         $semantics = $this->semantics($descriptors, $ext);
         $tags = $this->tags($profile->tags, $ext);
-        $htmlTitle = htmlspecialchars($profile->title);
+        $htmlTitle = htmlspecialchars($profile->title ?: 'ALPS');
         $htmlDoc = nl2br(htmlspecialchars($profile->doc));
         $profileImage = $mode === DumpDocs::MODE_HTML ? 'docs/asd.html' : 'profile.svg';
         $md = <<<EOT
@@ -57,7 +57,7 @@ public function __construct(Profile $profile, string $mode = DumpDocs::MODE_HTML
 {$semantics}{$tags}{$linkRelations}
 EOT;
         $this->file = sprintf('%s/index.%s', dirname($profile->alpsFile), $ext);
-        $this->content = $mode === DumpDocs::MODE_MARKDOWN ? $md : (new MdToHtml())('ALPS', $md);
+        $this->content = $mode === DumpDocs::MODE_MARKDOWN ? $md : (new MdToHtml())($htmlTitle, $md);
     }
 
     /**

diff --git a/tests/Fake/title.json b/tests/Fake/title.json
@@ -0,0 +1,7 @@
+{
+  "$schema": "https://alps-io.github.io/schemas/alps.json",
+  "alps": {
+    "title": "Title",
+    "descriptor": []
+  }
+}
diff --git a/tests/IndexPageTest.php b/tests/IndexPageTest.php
@@ -17,11 +17,13 @@ public function testInvoke(): string
         return $html;
     }
 
-    public function testInvokeMarkdownMode(): void
+    public function testInvokeMarkdownMode(): string
     {
         $alpsFile = __DIR__ . '/Fake/alps.json';
         $content = (new IndexPage(new Profile($alpsFile, new LabelName()), DumpDocs::MODE_MARKDOWN))->content;
         $this->assertStringContainsString('[About](docs/semantic.About.md) (semantic)', $content);
+
+        return $content;
     }
 
     /**
@@ -77,4 +79,36 @@ public function testMultipleLinkRelationsString(): void
         $this->assertStringContainsString('<li>rel: about <a rel="about" href="https://github.com/alps-asd/app-state-diagram/">https://github.com/alps-asd/app-state-diagram/</a></li>', $html);
         $this->assertStringContainsString('<li>rel: repository <a rel="repository" href="https://github.com/alps-asd/app-state-diagram/">https://github.com/alps-asd/app-state-diagram/</a></li>', $html);
     }
+
+    public function testTitle(): void
+    {
+        $alpsFile = __DIR__ . '/Fake/title.json';
+        $html = (new IndexPage(new Profile($alpsFile, new LabelName())))->content;
+
+        $this->assertStringContainsString('<title>Title</title>', $html);
+    }
+
+    public function testTitleMarkdownMode(): void
+    {
+        $alpsFile = __DIR__ . '/Fake/title.json';
+        $content = (new IndexPage(new Profile($alpsFile, new LabelName()), DumpDocs::MODE_MARKDOWN))->content;
+
+        $this->assertStringContainsString('# Title', $content);
+    }
+
+    /**
+     * @depends testInvoke
+     */
+    public function testNoTitle(string $content): void
+    {
+        $this->assertStringContainsString('<title>ALPS</title>', $content);
+    }
+
+    /**
+     * @depends testInvokeMarkdownMode
+     */
+    public function testNoTitleMarkdownMode(string $content): void
+    {
+        $this->assertStringContainsString('# ALPS', $content);
+    }
 }