Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ALPS profile title to the title element of index.html #156

Merged
merged 4 commits into from
May 28, 2022

Conversation

NaokiTsuchiya
Copy link
Member

@NaokiTsuchiya NaokiTsuchiya commented May 28, 2022

Fixed #155.

When alps.title is not defined, ALPS is set to the title element of index.html in HTML mode, and set to heading level 1 in markdown mode.

@NaokiTsuchiya NaokiTsuchiya requested a review from koriym May 28, 2022 07:09
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #156 (a9d5615) into master (4fd7b61) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #156   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       330       331    +1     
===========================================
  Files             32        32           
  Lines            860       860           
===========================================
  Hits             860       860           
Impacted Files Coverage Δ
src/IndexPage.php 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@koriym koriym merged commit 64f0f3d into alps-asd:master May 28, 2022
@NaokiTsuchiya NaokiTsuchiya deleted the issue/155 branch May 28, 2022 07:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ALPS title property in INDEX.HTML document
2 participants