Skip to content

Commit

Permalink
🐛 Remove golangci-lint action as it doesn't work
Browse files Browse the repository at this point in the history
Lets just remove this for now, since it doesn't work but blocks merges.

Fixes kubernetes-sigs#2268
  • Loading branch information
alvaroaleman committed Apr 11, 2023
1 parent 53057ba commit 9253ea9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 24 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/golangci-lint.yml

This file was deleted.

4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ $(GO_APIDIFF): $(TOOLS_DIR)/go.mod # Build go-apidiff from tools folder.
$(CONTROLLER_GEN): $(TOOLS_DIR)/go.mod # Build controller-gen from tools folder.
cd $(TOOLS_DIR) && go build -tags=tools -o bin/controller-gen sigs.k8s.io/controller-tools/cmd/controller-gen

$(GOLANGCI_LINT): .github/workflows/golangci-lint.yml # Download golanci-lint using hack script into tools folder.
$(GOLANGCI_LINT):
hack/ensure-golangci-lint.sh \
-b $(TOOLS_BIN_DIR) \
$(shell cat .github/workflows/golangci-lint.yml | grep version | sed 's/.*version: //')
v1.51.1

## --------------------------------------
## Linting
Expand Down

0 comments on commit 9253ea9

Please sign in to comment.