Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint action is failing incorrectly #2268

Closed
alvaroaleman opened this issue Apr 10, 2023 · 1 comment
Closed

golangci-lint action is failing incorrectly #2268

alvaroaleman opened this issue Apr 10, 2023 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alvaroaleman
Copy link
Member

See for example https://github.com/kubernetes-sigs/controller-runtime/actions/runs/4654252286/jobs/8235825217?pr=2259

It started failing without us doing any changes on PRs that are unrelated to the failure. It also seems it complains about something that got deprecated in go 1.20, but we use go 1.19

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2023
alvaroaleman added a commit to alvaroaleman/controller-runtime that referenced this issue Apr 11, 2023
Lets just remove this for now, since it doesn't work but blocks merges.

Fixes kubernetes-sigs#2268
alvaroaleman added a commit to alvaroaleman/controller-runtime that referenced this issue Apr 11, 2023
Lets just remove this for now, since it doesn't work but blocks merges.

Fixes kubernetes-sigs#2268
@vincepri
Copy link
Member

@alvaroaleman I think #2272 should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants