Improved: made whole permission item card clickable (hotwax#136)

amansinghbais · Jul 15, 2024 · 4c02fc2 · 4c02fc2
1 parent 3219d44
commit 4c02fc2
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/components/PermissionItems.vue b/src/components/PermissionItems.vue
@@ -29,13 +29,13 @@
       </ion-item-divider>
 
       <section v-if="group.groupId !== 'SGC_HIDDEN'">
-        <ion-card v-for="permission in group.permissions" :key="permission.permissionId">
+        <ion-card v-for="permission in group.permissions" :key="permission.permissionId" button @click="updatePermissionAssociation(permission)">
           <ion-card-header>
             <div>
               <ion-card-title>{{ permission.permissionId }}</ion-card-title>
               <ion-card-subtitle>{{ permission.description }}</ion-card-subtitle>
             </div>
-            <ion-checkbox :disabled="permission.isChecked ? !hasPermission(Actions.APP_PERMISSION_UPDATE) : !hasPermission(Actions.APP_PERMISSION_CREATE)" :checked="permission.isChecked" @click.prevent="updatePermissionAssociation($event, permission)" />
+            <ion-checkbox :disabled="permission.isChecked ? !hasPermission(Actions.APP_PERMISSION_UPDATE) : !hasPermission(Actions.APP_PERMISSION_CREATE)" :checked="permission.isChecked"  />
           </ion-card-header>
         </ion-card>
       </section>
@@ -107,9 +107,7 @@ export default defineComponent({
     async updateQuery() {
       await this.store.dispatch('permission/updateQuery', this.query)
     },
-    async updatePermissionAssociation(event: any, permission: any) {
-      event.stopImmediatePropagation();
-
+    async updatePermissionAssociation(permission: any) {
       let resp = {} as any;
       const payload = {
         groupId: this.currentGroup.groupId,
@@ -153,7 +151,6 @@ export default defineComponent({
           showToast(translate("Security group permission association successfully updated."))
           await this.store.dispatch('permission/updateCurrentGroupPermissions', { groupId: this.currentGroup.groupId, currentPermissions})
           this.store.dispatch('permission/checkAssociated')
-          event.target.checked = !permission.isChecked
         } else {
           throw resp.data
         }