Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make whole permission item clickable #136

Closed
dt2patel opened this issue Feb 29, 2024 · 2 comments
Closed

Make whole permission item clickable #136

dt2patel opened this issue Feb 29, 2024 · 2 comments
Assignees
@Adameddy26
Labels
enhancement New feature or request release-v1.11.0

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

The entire permission item should be clickable and it should also have a hover effect to acknowledge that the users cursor.

adding UI later
@dt2patel dt2patel self-assigned this Feb 29, 2024
@dt2patel dt2patel moved this to 📅 Planned in Digital Experience Platform Mar 1, 2024
@dt2patel dt2patel assigned ravilodhi and unassigned dt2patel Jul 15, 2024
@dt2patel
Copy link
Contributor Author

This UI pattern is already done in ATP app, so we just need to replicate that here.

@ravilodhi ravilodhi assigned amansinghbais and unassigned ravilodhi Jul 15, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jul 15, 2024
amansinghbais added a commit to amansinghbais/user-management that referenced this issue Jul 15, 2024
@amansinghbais
Improved: made whole permission item card clickable (hotwax#136)
4c02fc2
amansinghbais added a commit to amansinghbais/user-management that referenced this issue Jul 15, 2024
@amansinghbais
Reverted: unwanted extra space in tag (hotwax#136)
bf73dbc
@amansinghbais amansinghbais mentioned this issue Jul 15, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jul 15, 2024
ravilodhi added a commit that referenced this issue Jul 15, 2024
@ravilodhi
Merge pull request #251 from amansinghbais/#136
20b36d5 
Improved: made whole permission item card clickable (#136)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 17, 2024
@amansinghbais amansinghbais removed their assignment Jul 17, 2024
@Adameddy26 Adameddy26 self-assigned this Sep 27, 2024
@Adameddy26 Adameddy26 added enhancement New feature or request release-v1.11.0 labels Sep 27, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Sep 27, 2024
@Adameddy26
Copy link

Verified and working fine in release v1.11.0. Hence, closing it.

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-v1.11.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravilodhi @dt2patel @amansinghbais @Adameddy26