Support turbo mode for better latency but burn more power on CPU & NPU #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mamin506
commented
Sep 11, 2024
•
mamin506
commented
- Mailbox channel support three types: MGMT, USER_NORMAL and USER_POLL
- MGMT channel is interrupt based and good for not critical path.
- USER_NORMAL channel is interrupt based and good for critical path.
- USER_POLL channel is polling based and good for critical path which needs the best latency.
- Support "xrt-smi configure --pmode turbo"
- Only when no context is opened, change pmode from/to turbo are allowed.
- In turbo mode, all contexts are creating USER_POLL mailbox channel for best latency.
- Support hwq::poll_command() in shim
- Add shim_test for polling
| test name | ID (wait in ioctl) | ID (polling) |
|---|---|---|
| latency | 25 | 41 |
| throughput | 40 | 42 |
| runlist latency | 39 | 43 |
| runlist throughput | 30 | 44 |
Signed-off-by: Min Ma <min.ma@amd.com>
Signed-off-by: Min Ma <min.ma@amd.com>
Signed-off-by: Min Ma <min.ma@amd.com>
maxzhen
requested changes
Sep 11, 2024
src/driver/amdxdna/aie2_pm.c
Outdated
| @@ -41,7 +67,7 @@ int aie2_pm_set_mode(struct amdxdna_dev_hdl *ndev, enum amdxdna_power_mode_type | |||
| if (ndev->pw_mode == target) | |||
| return 0; | |||
|
|
|||
| if (target == POWER_MODE_LOW || target == POWER_MODE_MEDIUM) | |||
| if (target != POWER_MODE_DEFAULT && target != POWER_MODE_TURBO) | |||
There was a problem hiding this comment.
We need to support performance/default/turbo.
test/shim_test/io_test.cpp
Outdated
| if (io_test_parameters.wait == IO_TEST_POLL_WAIT) { | ||
| auto start = clk::now(); | ||
| while(!hwq->poll_command(bo->get())) { | ||
| auto now = clk::now(); |
There was a problem hiding this comment.
It might be too heavy to call clk::now() for every poll.
Signed-off-by: Min Ma <min.ma@amd.com>
maxzhen
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.