Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Commit

Permalink
chore(sample-modules): support node 18 (#1132) (#1136)
Browse files Browse the repository at this point in the history
  • Loading branch information
@JAdshead
JAdshead authored Sep 22, 2023
1 parent 1372719 commit f46a222
Show file tree
Hide file tree
Showing 25 changed files with 3,501 additions and 3,065 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ stats.json
.dev
.sass_cache
.webpack-stats*
.esbuild-stats*
.build-meta.json
.build-cache
bundle.integrity.manifest.json
Expand Down
3 changes: 2 additions & 1 deletion __tests__/integration/one-app.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ describe('Tests that require Docker setup', () => {
await tearDownTestRunner({ browser });
writeModuleMap(originalModuleMap);
});

test('one-app starts up successfully with a bad module', async () => {
const loggedError = await requiredExternalsError;
const [,
Expand Down Expand Up @@ -768,7 +769,7 @@ describe('Tests that require Docker setup', () => {
});

test('fails to get external `react-intl` for child module as an unsupplied `requiredExternal` - logs failure', async () => {
const requiredExternalsErrorMatch = /Failed to get external react-intl from root module/;
const requiredExternalsErrorMatch = /External 'react-intl' is required by cultured-frankie, but is not provided by the root module/;

const requiredExternalsError = searchForNextLogMatch(requiredExternalsErrorMatch);
await addModuleToModuleMap({
Expand Down
6,518 changes: 3,476 additions & 3,042 deletions package-lock.json
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"@americanexpress/env-config-utils": "^2.0.2",
"@americanexpress/fetch-enhancers": "^1.1.3",
"@americanexpress/lumberjack": "^1.1.4",
"@americanexpress/one-app-bundler": "^6.20.0",
"@americanexpress/one-app-bundler": "^6.21.2",
"@americanexpress/one-app-ducks": "^4.4.2",
"@americanexpress/one-app-router": "^1.1.0",
"@americanexpress/vitruvius": "^2.0.2",
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/cultured-frankie/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"redux": "^4.2.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/cultured-frankie/0.0.1/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"redux": "^4.2.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.15.0",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/frank-lloyd-root/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"redux": "^4.1.1"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/frank-lloyd-root/0.0.1/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"redux": "^3.0.6"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/frank-lloyd-root/0.0.2/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"redux": "^4.1.1"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/frank-lloyd-root/0.0.3/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"redux": "^4.2.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2",
"webpack": "^4.46.0"
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/frank-the-parrot/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-dom": "^16.14.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/franks-burgers/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"react-dom": "^16.14.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/healthy-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"react-redux": "^7.2.8"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/late-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-dom": "^16.14.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/late-frank/0.0.1/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-intl": "^3.12.1"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/late-frank/0.0.2/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"react-dom": "^16.14.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/needy-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"redux-thunk": "^2.4.1"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/needy-frank/0.0.1/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"redux-thunk": "^2.4.1"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/picky-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-dom": "^16.14.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/picky-frank/0.0.1/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-dom": "^16.14.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/preview-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"redux": "^4.2.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/ssr-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"react-helmet": "^5.2.1"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/unhealthy-frank/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"semver": "7.3.5"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.15.0",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/vitruvius-franklin/0.0.0/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"redux": "^4.2.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.15.0",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion prod-sample/sample-modules/vitruvius-franklin/0.0.1/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"redux": "^4.2.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.14.1",
"@americanexpress/one-app-bundler": "^6.21.1",
"babel-preset-amex": "^4.0.0",
"rimraf": "^3.0.2"
}
Expand Down

0 comments on commit f46a222

Please sign in to comment.