Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(sample-modules): support node 18 (#1132) #1136

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

JAdshead
Copy link
Contributor

Description

backport for - #1132

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

* chore(sample-modules): support node 18

* chore(integration-tests): update spec to look for new message

* fix(holocron): update 1.8.1
@JAdshead JAdshead force-pushed the chore/node-18-sample-modules branch from 9a07a9f to 150f74b Compare September 20, 2023 18:34
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Size Change: 0 B

Total Size: 663 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 161 kB
./build/app/app~vendors.js 377 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 111 kB

compressed-size-action

@JAdshead JAdshead force-pushed the chore/node-18-sample-modules branch from 360c2a7 to 39c1c56 Compare September 22, 2023 18:08
@JAdshead JAdshead marked this pull request as ready for review September 22, 2023 18:26
@JAdshead JAdshead requested review from a team as code owners September 22, 2023 18:26
@10xLaCroixDrinker 10xLaCroixDrinker merged commit f46a222 into 5.x.x Sep 22, 2023
6 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the chore/node-18-sample-modules branch September 22, 2023 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants