changes for amethyst shadow mapping #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
bors r=omni-viral |
bors bot
added a commit
that referenced
this pull request
Sep 21, 2019
191: changes for amethyst shadow mapping r=omni-viral a=Frizi This is a commit with changes I had to make while working on shadow mapping. The set includes: - fix for broken serde feature after conversion to u32 spirv slices (`serde_bytes_u32`) - removal of unnecessary assertion on spirv buffer length - allow adding dynamic nodes to graph - Allow creating `DescBuilder` with public `new` - always pick first layer for bound attachments, comment explains why - allow llvm inlining to better optimize texture conversion common cases The rest is all pretty much just rustfmt. We probably need to add a CI step that verifies that, as we have quite a lot of noise due to not formatting the code immediately. Co-authored-by: Frizi <frizi09@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit with changes I had to make while working on shadow mapping. The set includes:
serde_bytes_u32)DescBuilderwith publicnewThe rest is all pretty much just rustfmt. We probably need to add a CI step that verifies that, as we have quite a lot of noise due to not formatting the code immediately.