Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating spirv shader from byte array #213

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Allow creating spirv shader from byte array #213

merged 1 commit into from
Sep 28, 2019

Conversation

Frizi
Copy link
Member

@Frizi Frizi commented Sep 24, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files           6        6           
  Lines         169      169           
=======================================
  Hits          148      148           
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5a4a1...9bfe9d7. Read the comment docs.

@Frizi Frizi mentioned this pull request Sep 25, 2019
Closed
@Frizi
Copy link
Member Author

Frizi commented Sep 27, 2019

bors r=jaynus

bors bot added a commit that referenced this pull request Sep 27, 2019
@bors @Frizi
Merge #213
28ab593 
213: Allow creating spirv shader from byte array r=jaynus a=Frizi



Co-authored-by: Frizi <frizi09@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 27, 2019

Timed out

@Frizi
Copy link
Member Author

Frizi commented Sep 28, 2019

bors retry

bors bot added a commit that referenced this pull request Sep 28, 2019
@bors @Frizi
Merge #213
90ea766 
213: Allow creating spirv shader from byte array r=jaynus a=Frizi



Co-authored-by: Frizi <frizi09@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2019

Build succeeded

@bors bors bot merged commit 9bfe9d7 into amethyst:master Sep 28, 2019
@parasyte
Copy link

FWIW this PR introduces undefined behavior when &[u8] is not aligned to a 4-byte boundary. This topic came up recently in another project: ash-rs/ash#245 (comment) and has been discussed at length elsewhere.

@Ralith
Copy link

Ralith commented Oct 27, 2019

That's not actually the case. This calls the read_spirv helper to copy the input into a Vec<u32> (and fix up endianness if necessary).

@parasyte
Copy link

Ohh, yes, sorry. 😐 Nothing to see here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaynus jaynus jaynus approved these changes

@zakarumych zakarumych Awaiting requested review from zakarumych

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Frizi @codecov-io @parasyte @Ralith @jaynus