Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example notebook for rigid body dynamics #261

Merged
merged 12 commits into from
Oct 17, 2024

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Oct 10, 2024

This PR adds an example notebook for showing the use of JaxSim as a multibody dynamics library. Moreover, some refinements to the existing examples have been made.

Closes #194


📚 Documentation preview 📚: https://jaxsim--261.org.readthedocs.build//261/

@flferretti flferretti self-assigned this Oct 10, 2024
@flferretti flferretti force-pushed the feature/example_computation_nb branch 2 times, most recently from e5c606c to 0e2fbd3 Compare October 11, 2024 09:52
@flferretti flferretti marked this pull request as ready for review October 11, 2024 09:52
@flferretti flferretti force-pushed the feature/example_computation_nb branch from 0e2fbd3 to db74a47 Compare October 11, 2024 13:44
@diegoferigo diegoferigo force-pushed the feature/example_computation_nb branch 4 times, most recently from ea557b3 to ea75257 Compare October 14, 2024 07:28
@diegoferigo
Copy link
Member

@flferretti I'm done with my updates to the notebook. Feel free to either review the changes or directly update it, if needed. In order to run successfully, it needs an unmerged change from the ongoing contact refactoring.

@flferretti flferretti force-pushed the feature/example_computation_nb branch from ea75257 to 4dad874 Compare October 14, 2024 08:44
@flferretti
Copy link
Collaborator Author

Thanks a lot Diego! I have amended the last commit to remove the cell outputs, for the rest it looks great

@flferretti flferretti force-pushed the feature/example_computation_nb branch 3 times, most recently from 5d342a7 to 83e2195 Compare October 17, 2024 10:15
@diegoferigo
Copy link
Member

I am experience a broken rendering of video on the notebooks. Regardless, let me merge #265 first, then I'll rebase this PR on top of that one.

@flferretti
Copy link
Collaborator Author

I am experience a broken rendering of video on the notebooks. Regardless, let me merge #265 first, then I'll rebase this PR on top of that one.

If you look at the built docs in the PR description, the videos work fine. Do you have that problem only locally?

@diegoferigo
Copy link
Member

I am experience a broken rendering of video on the notebooks. Regardless, let me merge #265 first, then I'll rebase this PR on top of that one.

If you look at the built docs in the PR description, the videos work fine. Do you have that problem only locally?

It was here, #265 (comment). My bad, I moved an import without also moving the export of MUJOCO_GL.

@diegoferigo diegoferigo self-assigned this Oct 17, 2024
@flferretti flferretti merged commit 54baf36 into main Oct 17, 2024
24 checks passed
@flferretti flferretti deleted the feature/example_computation_nb branch October 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more advanced example notebooks
2 participants