Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default http client #35

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

duhruh
Copy link
Contributor

@duhruh duhruh commented Feb 28, 2021

I think it's useful to use the default client here, it allows us to instrument our own client if need be. This is just the simplest way to accomplish this. Ideally I would like to pass this in via a struct type field, but didn't wanna deal with the refactor overhead of that.

@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #35 (d006945) into master (9410002) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   68.35%   68.35%           
=======================================
  Files           5        5           
  Lines        1163     1163           
=======================================
  Hits          795      795           
  Misses        201      201           
  Partials      167      167           
Impacted Files Coverage Δ
huego.go 74.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9410002...d006945. Read the comment docs.

@amimof
Copy link
Owner

amimof commented Mar 10, 2021

@duhruh Thanks for this 👏 Looks good to me.

@amimof amimof merged commit b803c13 into amimof:master Mar 10, 2021
@yunginnanet
Copy link
Contributor

Ideally I would like to pass this in via a struct type field, but didn't wanna deal with the refactor overhead of that.

Good news, I did it for you! #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants