Add custom http.Client support. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
amimof
requested changes
Feb 21, 2022
There was a problem hiding this comment.
@yunginnanet Thanks for the contribution 👏 Please have a look at my suggestions
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 73.42% 73.53% +0.11%
==========================================
Files 5 5
Lines 1430 1436 +6
==========================================
+ Hits 1050 1056 +6
Misses 210 210
Partials 170 170
Continue to review full report at Codecov.
|
amimof
approved these changes
Feb 27, 2022
|
@yunginnanet Looks good 👍 Also, I’ve started working on version 2 with Bridge V2 API support. Would you be interested in helping out? #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added the ability to use a custom http.Client when interacting with bridges. My particular use-case comes from all of my lighting being segmented off, this allows for me to use my router as a middle-man via an SSH tunnel. However, I feel there are many, many use-cases.
- How I did it
I created a new function similar to New called NewCustom, it is just about the same except for it allows you to pass in your own http.Client. I then refactored all of the unexported http functions (get, put etc) to be methods of Bridge. This allows them to function using http.DefaultClient during normal operations, but with the custom http.Client otherwise.
- How to verify it
I've not only verified that this works for my use-case, but frankly making the testcases work (I didn't realize how httpmock had worked until today) was more work than the modification itself. So I think CI does a pretty good job of verification :)
- Description for the CHANGELOG