-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hue v2 support for the upcoming v2.0.0 release #52
Open
amimof
wants to merge
10
commits into
master
Choose a base branch
from
hue-v2-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 73.53% 64.80% -8.74%
==========================================
Files 5 12 +7
Lines 1436 1858 +422
==========================================
+ Hits 1056 1204 +148
- Misses 210 462 +252
- Partials 170 192 +22
Continue to review full report at Codecov.
|
* Work in progress * V2 version of huego is under `v2/`
The `io.NopCloser` constructor is not available in Go 1.15
* You may now use one `Client` for many `Requests` * Users may provide their own custom `http.Client`
* Client is just a simple generic HTTP rest client * A client implementation for each version of the API with the SDK-level interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Hue API V2
Features
v2/
. Folder structure is not final at this point and is sobject to changeClient
struct which is the type used to interact with the Hue API. Instead of using the Bridge type. The Bridge type is now just a regular struct that represents the bridge resource in the V2 API.CLIPClient
which is a general purpose HTTP client. Sort of like a REST client but for Hue briges specifically.CLIPClient
usesRequest
&Response
types to communicate with Hue briges through aClient
type.http.Client
if they want.Progress