forked from teambit/bit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #6 from teambit/master
[pull] master from teambit:master
- Loading branch information
Showing
167 changed files
with
5,555 additions
and
4,759 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
e2e/fixtures/extensions/multiple-compilers-env/babel.config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"presets": ["@babel/preset-env", "@babel/typescript"], | ||
"plugins": [ | ||
"@babel/plugin-proposal-class-properties" | ||
"@babel/plugin-transform-class-properties" | ||
], | ||
"sourceMaps": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import { IssuesClasses } from '@teambit/component-issues'; | ||
import { expect } from 'chai'; | ||
import Helper from '../../src/e2e-helper/e2e-helper'; | ||
import NpmCiRegistry, { supportNpmCiRegistryTesting } from '../npm-ci-registry'; | ||
|
||
describe('bit delete command', function () { | ||
let helper: Helper; | ||
let npmCiRegistry: NpmCiRegistry; | ||
this.timeout(0); | ||
before(() => { | ||
helper = new Helper(); | ||
}); | ||
after(() => { | ||
helper.scopeHelper.destroy(); | ||
}); | ||
/** | ||
* comp1 -> comp2 -> comp3 | ||
* deleting comp2 and comp3, now comp1 has a missing dependency, installing comp2 as a package from main. | ||
* all should be fine now. however, when snapping, it used to check for issues also the deleted components. | ||
* this makes sure that deleted components are not part of issues-checking for both: bit snap and bit status. | ||
*/ | ||
(supportNpmCiRegistryTesting ? describe : describe.skip)( | ||
'deleting two components which are dependency of each other then installing the missing dep', | ||
() => { | ||
before(async () => { | ||
helper = new Helper({ scopesOptions: { remoteScopeWithDot: true } }); | ||
helper.scopeHelper.setNewLocalAndRemoteScopes(); | ||
helper.fixtures.populateComponents(3); | ||
npmCiRegistry = new NpmCiRegistry(helper); | ||
npmCiRegistry.configureCiInPackageJsonHarmony(); | ||
await npmCiRegistry.init(); | ||
helper.command.tagAllComponents(); | ||
helper.command.export(); | ||
helper.command.createLane(); | ||
helper.command.snapAllComponentsWithoutBuild('--unmodified'); | ||
helper.command.export(); | ||
helper.command.softRemoveOnLane('comp3'); | ||
helper.command.softRemoveOnLane('comp2'); | ||
helper.command.install(helper.general.getPackageNameByCompName('comp2')); | ||
}); | ||
after(() => { | ||
npmCiRegistry.destroy(); | ||
}); | ||
it('bit status should not show RemovedDependencies issues', () => { | ||
helper.command.expectStatusToNotHaveIssue(IssuesClasses.RemovedDependencies.name); | ||
}); | ||
it('bit snap should fail due to removedDependencies error', () => { | ||
expect(() => helper.command.snapAllComponentsWithoutBuild()).not.to.throw(); | ||
}); | ||
} | ||
); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.