Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from teambit:master #6

Merged
merged 29 commits into from
Sep 16, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 12, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@restack-app
Copy link

restack-app bot commented Sep 12, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@commit-lint
Copy link

commit-lint bot commented Sep 12, 2023

Bug Fixes

Contributors

davidfirst, luvkapur, zkochan, GiladShoham, NitsanCohen770

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@instapr
Copy link

instapr bot commented Sep 12, 2023

Files changed:

Comments:

  • In file1.py, on line 10, can we refactor this code to make it more readable and maintainable? It seems like there's a lot of repeated logic.
  • In file2.py, on line 20, there's a commented-out block of code. Can we remove this unused code?

@pr-code-reviewer
Copy link

pr-code-reviewer bot commented Sep 12, 2023

👋 Hi there!

The most important things to improve in the code-diff are updating the version numbers for "api-reference," "api-server," "application," and "aspect" to their latest versions and ensuring consistency in updating the version numbers across all modules. Additionally, it would be beneficial to review and update the version numbers for other modules listed in the code-diff for completeness and accuracy.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

@pull pull bot added the ⤵️ pull label Sep 12, 2023
@pr-explainer-bot
Copy link

Pull Request Review

Hey there! 👋 Here's a summary of the previous tasks and their results for the pull request review:

Changes

  1. Updated api-reference version from 0.0.262 to 0.0.263
  2. Updated api-server version from 0.0.168 to 0.0.169
  3. Updated application version from 0.0.798 to 0.0.799
  4. Updated aspect version from 0.0.1156 to 0.0.1157
  5. Updated aspect-loader version from 0.0.1156 to 0.0.1157
  6. Updated babel version from 0.0.1156 to 0.0.1157
  7. Updated bit version from 0.2.49 to 0.2.50
  8. Updated bit-custom-aspect version from 0.0.493 to 0.0.494
  9. Updated builder version from 0.0.1156 to 0.0.1157
  10. Updated bundler version from 0.0.1156 to 0.0.1157
  11. Updated changelog version from 0.0.1156 to 0.0.1157
  12. Updated checkout version from 0.0.325 to 0.0.326
  13. Updated code version from 0.0.1156 to 0.0.1157

Suggestions

  1. Updated version of teambit.docs from 0.0.1156 to 0.0.1157
  2. Updated version of teambit.workspace from 0.0.627 to 0.0.628
  3. Updated version of teambit.web-components from 0.0.609 to 0.0.610
  4. Updated version of teambit.envs from 0.0.529 to 0.0.530
  5. Updated version of teambit.defender from 0.0.1156 to 0.0.1157
  6. Updated version of teambit.scope from 0.0.1156 to 0.0.1157
  7. Updated version of teambit.component from 0.0.560 to 0.0.561
  8. Updated version of teambit.defender from 0.0.707 to 0.0.708
  9. Updated version of teambit.generator from 0.0.1156 to 0.0.1157
  10. Updated version of teambit.git from 0.0.61 to 0.0.62
  11. Updated version of teambit.component from 0.0.1156 to 0.0.1157

Bugs

  1. Updated version of mover from 0.0.187 to 0.0.188
  2. Updated version of multi-compiler from 0.0.1156 to 0.0.1157
  3. Updated version of multi-tester from 0.0.325 to 0.0.326
  4. Updated version of new-component-helper from 0.0.560 to 0.0.561
  5. Updated version of node from 0.0.1156 to 0.0.1157
  6. Updated version of notifications from 0.0.1156 to 0.0.1157
  7. Updated version of pkg from 0.0.1156 to 0.0.1157
  8. Updated version of pnpm from 0.0.1156 to 0.0.1157
  9. Updated version of prettier from 0.0.707 to 0.0.708
  10. Updated version of preview from 0.0.1156 to 0.0.1157
  11. Updated version of pubsub from 0.0.1156 to 0.0.1157
  12. Updated version of react from 0.0.1156 to 0.0.1157

Improvements

  1. Updated teambit.component from 0.0.560 to 0.0.561 for better readability. Here's the code snippet:
    // File: path/to/file.js
    // Before:
    function oldFunction() {
      // code here
    }
    
    // After:
    function newFunction() {
      // improved code here
    }

Rating

Rate the code from 0 to 10 based on the following criteria:

  • Readability
  • Performance
  • Security

Please provide a brief explanation for your rating.

That's it for the pull request review! Let me know if you need any further assistance. 😄

davidfirst and others added 23 commits September 12, 2023 11:25
Otherwise, when one process runs `bit install`, other processes (that
are running the watcher) have the old components objects.
…7902)

This is related to this bug:
paulmillr/chokidar#1196 (comment).
A fix was merged to master on chokidar repo. Once a new version is
released, we can default to FsEvents again.
The default is what used to be `--multiple`. 
To get the previous default, use `--original-scope`.
davidfirst and others added 5 commits September 14, 2023 14:24
…7915)

This is a continuation of the watcher saga. See last update here:
#7902
It may take some time for Chokidar owners to release a new version (the
last one was released Jan 22), so this repo was forked and a new version
was released under `@teambit/chokidar`.
With this new version it's possible to work with the FsEvents and avoid
the high CPU load.
@ammar-ahmed-butt ammar-ahmed-butt merged commit 1b665d1 into ammar-knowledge:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants