-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supports for RN 0.71 #305
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Even with the changes of @JerakRus I'm still getting build errors:
|
Fixed all the build issues and upgraded the example project to v0.71 as well to be sure that is working well on Android and iOS. |
confirmed the build works now. App did not crash either |
Although this PR is great, the problem is that it won't work for older versions of this library after upgrading. It still has to be backward compatible some how because most projects are on older versions of react-native & we are still supporting both. So we need to find a way to still keep it backward compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has duplicated mrousavy/react-native-mmkv#480 and mrousavy/react-native-mmkv#499 without mentioning that and has carried over a few changes that are not relevant to this library. I've flagged two but there may be others that I missed given my unfamiliarity with the build process.
Starting from version 0.71, react native is not shipping the android folder (read more).
This library depends on the⚠️ This is a breaking change.
android
folder to build correctly, so this PR adds support for 0.71 and above and it's not backward compatible with older versions.DISCLAIMER: These changes were extracted from react-native-mmkv library, all credits to them.