Remove intl from required extensions; add add date/spl as required; add others to suggest #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
intl
isn't actually a requirement. I tried deploying changes merged in #2183 to Pantheon and upon doing so the plugin stopped initializing due to theintl
extension not being installed. In fact, the extension is not required as we do afunction_exists
check before using it:amp-wp/includes/class-amp-http.php
Lines 205 to 209 in 98c2545