Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove intl from required extensions; add add date/spl as required; add others to suggest #2190

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Remove intl from required extensions; add add date/spl as required; add others to suggest #2190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce528d4
Remove intl from required extensions
westonruter Apr 24, 2019
c57348a
Add suggested dependencies and additional required extensions
westonruter Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion amp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@
// See composer.json for this list.
$_amp_required_extensions = array(
'curl',
'date',
'dom',
'iconv',
'intl',
'libxml',
'spl',
);
$_amp_missing_extensions = array();
foreach ( $_amp_required_extensions as $_amp_required_extension ) {
Expand Down
8 changes: 7 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,20 @@
"require": {
"php": "^5.4 || ^7.0",
"ext-curl": "*",
"ext-date": "*",
"ext-dom": "*",
"ext-iconv": "*",
"ext-intl": "*",
"ext-libxml": "*",
"ext-spl": "*",
"cweagans/composer-patches": "1.6.5",
"fasterimage/fasterimage": "1.4.0",
"sabberworm/php-css-parser": "8.3.0"
},
"suggest": {
"ext-intl": "Enables use of idn_to_utf8() to convert punycode domains to UTF-8 for use with an AMP Cache.",
"ext-json": "Provides native implementation of json_encode()/json_decode().",
"ext-mbstring": "Used by PHP-CSS-Parser when working with stylesheets."
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "0.5.0",
"phpcompatibility/php-compatibility": "9.1.1",
Expand Down
7 changes: 3 additions & 4 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.