Pull the built block-libray package from Gutenberg SVN
#3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
pushed a commit
that referenced
this pull request
Nov 30, 2019
westonruter
added a commit
that referenced
this pull request
Nov 30, 2019
…id-markup-reason * 'develop' of github.com:ampproject/amp-wp: Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847) Update dependency @babel/plugin-transform-react-jsx to v7.7.4 (#3688) Update dependency @babel/plugin-proposal-class-properties to v7… (#3687) Update dependency @babel/cli to v7.7.4 (#3685) Update dependency browserslist to v4.7.3 (#3792) Update dependency postcss to v7.0.23 (#3791) Update dependency autoprefixer to v9.7.2 (#3679) For the Gallery block, use the recommended amp-lightbox-gallery
westonruter
added a commit
that referenced
this pull request
Nov 30, 2019
…nt/3365-paired-browsing * 'develop' of github.com:ampproject/amp-wp: (53 commits) Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847) Update dependency @babel/plugin-transform-react-jsx to v7.7.4 (#3688) Update dependency @babel/plugin-proposal-class-properties to v7… (#3687) Update dependency @babel/cli to v7.7.4 (#3685) Update dependency browserslist to v4.7.3 (#3792) Update dependency postcss to v7.0.23 (#3791) Update dependency autoprefixer to v9.7.2 (#3679) For the Gallery block, use the recommended amp-lightbox-gallery Add the -o flag to composer install for production build processes Make get_dimensions() private instead of public Remove optimize-autoloader from composer.json config, will apply this in build Also rename images to slides in Test_Carousel In Carousel, rename $images to $slides Commit Alain's suggestion to make `$images` private Update src/Component/Carousel.php Commit Alain's suggestion to make the Carousel class final Make $elements propert private again Edit DocBlocks, include correcting var tag Update the DocBlock of DOMElementList::add() Clone the DOMElementList in add(), and return the clone ...
westonruter
added a commit
that referenced
this pull request
Dec 19, 2019
* tag '1.4.2': (25 commits) Bump 1.4.2 Bump 'tested up to' to 5.3.2 Catch unfiltered requests when testing Crowsignal embed (#3956) Bump version 1.4.2-RC1 Bump 'Tested up to' to 5.3.1 Remove test case for paired browsing since broken in WP4.9 and would not pass in AMP 1.4 (#3928) Further refine is_exclusively_dependent and add tests (#3928) Only include hoverintent-js in dev mode if exclusive dependency of admin-bar (#3928) Include admin-bar script deps in dev mode (e.g. hoverintent-js) (#3928) Fix tests after security fix in WP 5.3.1 (r46896) (#3926) Add E2E tests to allow_failures Convert `theme_features` variable into `get_theme_config` function Only apply smooth scroll fix on 'Twenty Twenty' <= 1.0.0 Re-add smooth scrolling fix on WP < 5.3.1 No need to apply smooth scrolling fix for Twenty Twenty theme Bump stylesheet cache group after #3866 (#3880) Return allowed KSES tags if not an array (#3879) Bundle common font files for externalizing data: URLs (#3866) Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847) Optimize is_amp_allowed_attribute checking for reference points (#3815) ...
westonruter
pushed a commit
that referenced
this pull request
Jan 8, 2020
* Update wp-dev-lib package to fix Travis errors See: xwp/wp-dev-lib#310 * Update composer.lock * Make phpcs happy * Revert "Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)" This reverts commit 12c1d47 * Revert update of indirect packages * Update wp-dev-lib to 1.3.2
westonruter
pushed a commit
that referenced
this pull request
Jan 8, 2020
* Update wp-dev-lib package to fix Travis errors See: xwp/wp-dev-lib#310 * Update composer.lock * Make phpcs happy * Revert "Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)" This reverts commit 12c1d47 * Revert update of indirect packages * Update wp-dev-lib to 1.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test
AMP_Style_Sanitizer_Test::test_prioritized_stylesheetshas been failing for some time now in the PHPUnit test jobs on Travis that test against WP versions 5.0 and 5.1 (see here and here for example).Upon further investigation, these tests were failing because the CSS file
<WP_CORE_DIR>/wp-includes/css/dist/block-library/style.csswas missing due to WP Core styles not being built. This issue is only now surfacing as the Gutenberg plugin has been providing this file all this time, but since v7.0.0, this is no longer happening as the minimum WP version required to run the plugin has been bumped from 5.0 to 5.2, making the built CSS files no longer available in WP < 5.2.This PR fixes this issue by pulling the built
block-librarypackage from Gutenberg's SVN repo, which will include the built CSS files needed to run the test successfully.