Download required WP Core asset dependency files #310
Conversation
There was a problem hiding this comment.
Thanks for opening the pull request @pierlon! I've noticed this issue on some other project repos, too.
What do you think about using the full wp-includes directory from the release repo? I think we're using the source repo mainly to get the phpunit related helpers.
| @@ -585,6 +585,10 @@ function install_wp { | |||
| mkdir -p "$WP_CORE_DIR/src/wp-includes/css/dist/block-library" | |||
| touch "$WP_CORE_DIR/src/wp-includes/css/dist/block-library/style.css" | |||
|
|
|||
| # Download required asset dependency files | |||
| local SVN_CORE_URL=${SVN_URL/develop/core} | |||
There was a problem hiding this comment.
Could we use the full wp-includes directory from the release repository?
https://core.svn.wordpress.org/trunk/wp-includes
That would solve both the block-library issue above and this one.
There was a problem hiding this comment.
Sure that makes sense.
|
Is this change worth it? Core has just fixed this for trunk: https://core.trac.wordpress.org/changeset/47048 |
|
@swissspidy Oh, great -- that's a better fix! This fix has been released as 1.3.1 already. Do we still need to keep it for this fix? |
|
The change would resolve the |
|
This would also prevent issues such as ampproject/amp-wp#3847 from ever happening again. |
* Update wp-dev-lib package to fix Travis errors See: xwp/wp-dev-lib#310 * Update composer.lock * Make phpcs happy * Revert "Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)" This reverts commit 12c1d47 * Revert update of indirect packages * Update wp-dev-lib to 1.3.2
* Update wp-dev-lib package to fix Travis errors See: xwp/wp-dev-lib#310 * Update composer.lock * Make phpcs happy * Revert "Pull the built `block-libray` package from Gutenberg SVN if it does not exists (#3847)" This reverts commit 12c1d47 * Revert update of indirect packages * Update wp-dev-lib to 1.3.2
As of WordPress/wordpress-develop@a35e46a, an asset file is now generated for each WordPress JS dependency in Core. This creates a problem when running PHPUnit tests on Travis as these files are not generated during the WordPress setup process (as can be seen here for example).
This PR resolves this issue by downloading the
wp-includes/assets/distfolder from WordPress' Core SVN repo during the WordPress installation.